Increasingly I find it depending mostly on what the game was built for... I was raised, if you will, on PC point and shoots, and so my preference is for mouse and keyboard. But even a lot of AAA games these days that are console ports have noticeable pointer lag and aggressive reticule gravity or other aids. I find these really frustrating since they interfere with the 1:1 sense you get with motion on a mouse, so I'll switch to a controller instead.

Hogwarts Legacy is an example of a recent AAA release that has such heavy reticule gravity that sometimes the best strategy is to just hold an analog stick forward and not move it (e.g. in the broom races)... I hate this kind of thing but I feel like it's something you put up with as a PC gamer due to the popularity edge the consoles have. At least it tends to be games where fast aiming isn't a huge factor.

Playing something like UT or Quake, and so many more FPS benefit from the rapidity of the mouse, but timesplitters there's no other controller than the PS or Logitech dual joystick controller (which controlled that sub that imploded recently).

Really depends on the game. I usually get a lot faster and more precise adjustments using KBM, so I prefer that for games like shooters and anything where precise 3d movement or fast reactions is an issue.

Basically the only games I play with controller are the ones that are really well optimised for controller and kind of meh for KBM and the ones on my Switch.

as a kid i played keyboard and mouse for all the games i played at the time (backyard sports franchise and other humongous games like freddi fish, putt putt etc.) then i moved to ps2 and then later 360 so now i am much more inclined to use a controller