1012
GoOn (programming.dev)
you are viewing a single comment's thread
view the rest of the comments
[-] FauxPseudo@lemmy.world 313 points 1 year ago

Ok. This covers every ipv6 and ipv4 address.

"^\s*((([0-9A-Fa-f]{1,4}:){7}([0-9A-Fa-f]{1,4}|:))|(([0-9A-Fa-f]{1,4}:){6}(:[0-9A-Fa-f]{1,4}|((25[0-5]|2[0-4][0-9]|1[0-9][0-9]|[1-9]?[0-9])(.(25[0-5]|2[0-4][0-9]|1[0-9][0-9]|[1-9]?[0-9])){3})|:))|(([0-9A-Fa-f]{1,4}:){5}(((:[0-9A-Fa-f]{1,4}){1,2})|:((25[0-5]|2[0-4][0-9]|1[0-9][0-9]|[1-9]?[0-9])(.(25[0-5]|2[0-4][0-9]|1[0-9][0-9]|[1-9]?[0-9])){3})|:))|(([0-9A-Fa-f]{1,4}:){4}(((:[0-9A-Fa-f]{1,4}){1,3})|((:[0-9A-Fa-f]{1,4})?:((25[0-5]|2[0-4][0-9]|1[0-9][0-9]|[1-9]?[0-9])(.(25[0-5]|2[0-4][0-9]|1[0-9][0-9]|[1-9]?[0-9])){3}))|:))|(([0-9A-Fa-f]{1,4}:){3}(((:[0-9A-Fa-f]{1,4}){1,4})|((:[0-9A-Fa-f]{1,4}){0,2}:((25[0-5]|2[0-4][0-9]|1[0-9][0-9]|[1-9]?[0-9])(.(25[0-5]|2[0-4][0-9]|1[0-9][0-9]|[1-9]?[0-9])){3}))|:))|(([0-9A-Fa-f]{1,4}:){2}(((:[0-9A-Fa-f]{1,4}){1,5})|((:[0-9A-Fa-f]{1,4}){0,3}:((25[0-5]|2[0-4][0-9]|1[0-9][0-9]|[1-9]?[0-9])(.(25[0-5]|2[0-4][0-9]|1[0-9][0-9]|[1-9]?[0-9])){3}))|:))|(([0-9A-Fa-f]{1,4}:){1}(((:[0-9A-Fa-f]{1,4}){1,6})|((:[0-9A-Fa-f]{1,4}){0,4}:((25[0-5]|2[0-4][0-9]|1[0-9][0-9]|[1-9]?[0-9])(.(25[0-5]|2[0-4][0-9]|1[0-9][0-9]|[1-9]?[0-9])){3}))|:))|(:(((:[0-9A-Fa-f]{1,4}){1,7})|((:[0-9A-Fa-f]{1,4}){0,5}:((25[0-5]|2[0-4][0-9]|1[0-9][0-9]|[1-9]?[0-9])(.(25[0-5]|2[0-4][0-9]|1[0-9][0-9]|[1-9]?[0-9])){3}))|:)))(%.+)?\s*$"

[-] YIj54yALOJxEsY20eU@lemm.ee 106 points 1 year ago

Lord have mercy

[-] dannym@lemmy.escapebigtech.info 83 points 1 year ago* (last edited 1 year ago)

Please don't. Use regex to find something that looks like an IP then build a real parser. This is madness, its's extremely hard to read and a mistake is almost impossible to spot. Not to mention that it's slow.

Just parse [0-9]{1,3}.[0-9]{1,3}.[0-9]{1,3}.[0-9]{1,3} using regex (for v4) and then have some code check that all the octets are valid (and store the IP as a u32).

[-] Emma_Gold_Man@lemmy.dbzer0.com 11 points 1 year ago

And dupe check. 0.0.0.0 and 000.000.000.000 may both be valid, but they resolve the same

[-] azertyfun@sh.itjust.works 6 points 1 year ago

Fuck that, if for whatever reason I'm writing an IP validator by hand I'm disallowing leading zeros. Parsers are very inconsistent, some will parse 010 as 10, others as 0o10 == 8 (you can try that right now with a POSIX ping). Talk about a footgun.

[-] stringere@reddthat.com 6 points 1 year ago

some will parse 010 as 10, others as 0o10 == 8

...and that's me in the fetal position, thanks.

[-] dannym@lemmy.escapebigtech.info 3 points 1 year ago* (last edited 1 year ago)

Definitely, tho if you store it as a u32 that is fixed magically. Because 1.2.3.4 and 1.02.003.04 both map to the same number.

What I mean by storing it as a u32 is to convert it to a number, similar to how the IP gets sent over the wire, so for v4:

octet[3] | octet[2] << 8 | octet[1] << 16 | octet[0] << 24

or in more human terms:

(fourth octet) + (third octet * 256) + (second octet * 256^2) + (first octet * 256^3)
[-] p1mrx@sh.itjust.works 2 points 1 year ago

Because 1.2.3.4 and 1.02.003.04 both map to the same number.

But 10.20.30.40 and 010.020.030.040 map to different numbers. It's often best to reject IPv4 addresses with leading zeroes to avoid the decimal vs. octal ambiguity.

[-] dannym@lemmy.escapebigtech.info 2 points 1 year ago

I don't know why anyone would write their IPs in octal, but fair point

[-] p1mrx@sh.itjust.works 2 points 1 year ago

It's not about how people write them, it's how parsers parse them. IPv4 has been around since 1982, and most parsers interpret leading zeros as octal.

[-] Emma_Gold_Man@lemmy.dbzer0.com 2 points 1 year ago

True enough for database or dictionary storage, but a lot of times things get implemented in arrays where you still wind up with two copies of the same uint32.

[-] MsPenguinette@lemmy.world 51 points 1 year ago

IPv6 was a mistake. We should have just added an addition octet

[-] Centillionaire@kbin.social 75 points 1 year ago

That would allow for like, 2 trillion devices? Feels like a bandaid, my dude. Next you’re gonna suggest a giant ice cube in the ocean once a year to stop global warming.

[-] stoy@lemmy.zip 13 points 1 year ago

So add two more octets:

Moat companies will still just use something like 10.0.13.37.0.1

[-] 0xD@infosec.pub 11 points 1 year ago

IPv6 is not made with internal networks in mind lol

[-] dan@upvote.au 1 points 1 year ago

You can use a ULA if you want to. That's essentially the IPv6 equivalent of a private IP.

Why though? Having the same IP for both internal and external solves a bunch of issues. For example, you don't need to use split horizon DNS any more (which is where a host name has a different IP on your internal network vs on the internet). You just need to ensure your firewalls are set up properly, which you should do anyways.

[-] stoy@lemmy.zip -2 points 1 year ago

Never claimed it was, please quote me where I said as much

[-] dohpaz42@lemmy.world 17 points 1 year ago

My dude, you used the 10.xx private IP as an example. Why wouldn’t they assume you were referring to internal networks?

[-] stoy@lemmy.zip -2 points 1 year ago

I thought it was pretty clear with me adding 13.37 that I was making a joke, the earlier post spoke about how just adding one octet would still be too few addresses, so I joked about adding one more octet.

[-] dohpaz42@lemmy.world 3 points 1 year ago

I’m only pointing out why the other poster would make the assumption you were referring to an internal network. Do with it what you will.

[-] shasta@lemm.ee 9 points 1 year ago
[-] intensely_human@lemm.ee 6 points 1 year ago

Hurricanes cannot cross the equator. The equator is an imaginary line, and hence has zero mass. We can end every hurricane using zero point zero energy (0.0).

[-] alienzx@feddit.nl 4 points 1 year ago* (last edited 1 year ago)

You could follow this logic and add 2 alphanumeric digits before 4 numeric octets. E.g. xf.192.168.1.1

This would at least keep it looking like an IP and not a Mac address. Another advantage would be graceful ipv4 handling with a reserved range starting with "ip" like ip.10.10.10.1

[-] Nalivai@discuss.tchncs.de 17 points 1 year ago

Oh yeah, great, let's change the fundamental protocol on which all the networks in the world are based. Now two third of the devices in the world crashed because you tried to ping 192.168.0.0.1

[-] tilcica@lemm.ee 12 points 1 year ago

that WOULD be quite funny for the first second or 2....

[-] bjoern_tantau@swg-empire.de 4 points 1 year ago

Could have sped up adoption significantly.

[-] snor10@lemm.ee 6 points 1 year ago

They played us for absolute fools!

[-] FauxPseudo@lemmy.world 1 points 1 year ago

Plus the MAC address

[-] lnee@lemm.ee 1 points 1 year ago

IPv

heared of ipv5?

[-] rob64@startrek.website 37 points 1 year ago
[-] Patches@sh.itjust.works 20 points 1 year ago* (last edited 1 year ago)

Made that joke in an interview once.

They didn't think it was funny. They truly thought Regex was the solution to, but never the cause of, all problems.

They wanted to make a Regex to verify every single address in the world. Dodged a bullet

[-] rob64@startrek.website 9 points 1 year ago* (last edited 1 year ago)

Holy hell yeah you did. How would you go about doing that in a single expression? A bunch of back references to figure out the country? What if that's not included? Oy.

[-] Patches@sh.itjust.works 16 points 1 year ago* (last edited 1 year ago)

You wouldn't. It's not possible. Which is what I told them.

And why would you want to? Legally if you change the given address, and it fails to get delivered - that is on you. Not them.

Some countries have addresses that are literally 'Last house on the left by the Big Tree. Bumban(Neighborhood). NN (Country)'. Any US Centric validation would fail this but I assure you - mail gets delivered just fine.

[-] azertyfun@sh.itjust.works 4 points 1 year ago

The only valid regex is (.+). Maybe add a separate country field (especially because some Americans wholeheartedly believe that the entire world should understand that "foobar, TX" means "foobar, Texas, United States") (don't get me started on states whose abbreviations are also ISO country codes).

Unfortunately I guess business people only care about getting fewer support calls for missing shipping details, not correctness or a couple of calls from customers who live in the boonies. Then the proper answer is a form with a bunch of fields... which Americans will inevitably fuck up by making the "State" field mandatory despite most countries not having an equivalent.

What I'd really do is use one of those services that automatically fill on the address using google maps or whatever. Not perfect, probably not free, but a whole lot less work for presumably way fewer PEBCAKs from customers.

[-] Natanael@slrpnk.net 4 points 1 year ago

If you're using one of those services then PLEASE allow manual entry / override because I've had forms like that which I were blocked from filing in because it didn't acknowledge that my address existed.

[-] peter@feddit.uk 3 points 1 year ago

/.+(road|street).+/ resigns

[-] BeigeAgenda@lemmy.ca 31 points 1 year ago

It's always a treat to debug a regex of that size.

[-] SchizoDenji@lemm.ee 29 points 1 year ago

I knew there would be someone with the regex.

[-] takeda@lemmy.world 18 points 1 year ago* (last edited 1 year ago)

You're more of a perl programmer than network engineer :P

[-] hemko@lemmy.dbzer0.com 4 points 1 year ago
[-] 0x0@lemmy.dbzer0.com 2 points 1 year ago

Technically, this one also matches everything:

[-] shootwhatsmyname@lemm.ee 3 points 1 year ago* (last edited 1 year ago)

*exits the room*

this post was submitted on 15 Nov 2023
1012 points (95.7% liked)

Programmer Humor

19821 readers
778 users here now

Welcome to Programmer Humor!

This is a place where you can post jokes, memes, humor, etc. related to programming!

For sharing awful code theres also Programming Horror.

Rules

founded 2 years ago
MODERATORS